Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

made changes to bfs and vistors that didn't return bool #84

Merged
merged 6 commits into from
Jul 7, 2015

Conversation

sbromberger
Copy link
Owner

No description provided.

@IainNZ
Copy link
Contributor

IainNZ commented Jul 7, 2015

Add a test?

@sbromberger
Copy link
Owner Author

Yes - I want to but I don't know how to suppress println() output, which is what I need to/should do with traverse_graph_withlog(). Ideas?

@IainNZ
Copy link
Contributor

IainNZ commented Jul 7, 2015

Could use an IOBuffer instead of STDOUT?

@sbromberger
Copy link
Owner Author

Ah, ok. I'll change that then, and have it default to STDOUT. Thanks.

@sbromberger
Copy link
Owner Author

Yup, the visitor actually accepts an IO type. However: JuliaLang/julia#12050 .

@IainNZ
Copy link
Contributor

IainNZ commented Jul 7, 2015

Can't you make an IOBuffer() and then just throw it away?

@sbromberger
Copy link
Owner Author

Yes, of course. I was trying to do this with an IOStream() and not having much luck.

@sbromberger sbromberger force-pushed the hotfix-1 branch 2 times, most recently from 8e4881b to 22d4980 Compare July 7, 2015 21:46
This reverts commit dbf785610ef248a26ed5b3a95d7c5d05e447fb89, reversing
changes made to 5f69d5a.

more optimizations

trivial
sbromberger added a commit that referenced this pull request Jul 7, 2015
made changes to bfs and vistors that didn't return bool
@sbromberger sbromberger merged commit 99ab432 into master Jul 7, 2015
@sbromberger sbromberger deleted the hotfix-1 branch July 7, 2015 21:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants